Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add smoke tests for #290 #291

Closed
wants to merge 1 commit into from
Closed

add smoke tests for #290 #291

wants to merge 1 commit into from

Conversation

rijnhard
Copy link
Contributor

What changes did you make? (Give an overview)

only added smoke tests for #290

I think fixing this is a bit above my capability

@rijnhard rijnhard changed the title [WIP] add smoke tests for #290 add smoke tests for #290 Oct 26, 2020
@Trott Trott mentioned this pull request Dec 12, 2021
Closed
@mrmlnc mrmlnc mentioned this pull request Jan 1, 2022
Merged
@mrmlnc
Copy link
Owner

mrmlnc commented Jan 1, 2022

Fixed by #339. Thanks for the set of tests, @rijnhard.

@mrmlnc mrmlnc closed this Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rijnhard @mrmlnc